fix(iOS): remove FormSheet scroll view KVO observer synchronously on invalidate#4091
Merged
kkafar merged 5 commits intoMay 25, 2026
Merged
Conversation
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an iOS FormSheet-specific regression where a descendant ScrollView could remain clipped to the dismissed sheet’s height because a bounds KVO observer was removed too late (after the scroll view was already reused by the next pushed screen).
Changes:
- Remove the FormSheet descendant scroll view
boundsKVO observer synchronously at the start of-[RNSScreenView invalidateImpl](instead of deferring it to an async cleanup block). - Keep controller cleanup (
_controller = nil) deferred to the existingdispatch_asyncblock. - Add a minimal issue repro screen (
Test4090) and export it in the issue-tests index.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
ios/RNSScreen.mm |
Ensures the FormSheet scroll view KVO observer is removed immediately during invalidation to prevent reuse-related layout bugs. |
apps/src/tests/issue-tests/Test4090.tsx |
Adds a minimal navigation scenario reproducing “dismiss FormSheet + immediately push ScrollView screen” clipping. |
apps/src/tests/issue-tests/index.ts |
Exposes Test4090 in the issue-tests registry so it appears in the test app. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kkafar
approved these changes
May 25, 2026
Member
|
The layout direction iOS e2e test failing seems unrelated. @LKuchno FYI |
Contributor
Author
|
I am glad I could help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4090
After dismissing FormSheet, pushed screen ScrollView is clipped to sheet height.
FormSheet KVO observer not removed before scroll view is reused by the next screen.
Changes
-invalidateImpl, instead of inside thedispatch_asyncblock introduced in feat(iOS, Stack v4): Use new invalidation callback on Fabric #3728_controller - nilto the async block (unchanged)Test4090as a minimal repro for dismissing a form sheet and immediately pushing a screen with a full-heightScrollViewBefore & after - visual documentation
Before
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-05-22.at.22.59.32.2.mov
After
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-05-24.at.18.38.05.mov
Test plan
Checklist